Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft JEP #10

Merged
merged 52 commits into from
Mar 3, 2022
Merged

draft JEP #10

merged 52 commits into from
Mar 3, 2022

Conversation

fcollonval
Copy link
Member

I opened this PR tot be able to use the comment feature.

Copy link
Member Author

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echarles here are some comments to start the discussion. Overall I confirm we are aligned on the goal for this JEP.

jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
echarles and others added 10 commits February 12, 2022 07:16
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
@echarles
Copy link
Member

Thx a lot @fcollonval I have merged you suggestions and replied on 2 comments. I will merge once you undraft. Then we can further discuss and plan the JEP submission.

jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
Copy link
Member Author

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some minor additional elements and some typos

jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
echarles and others added 6 commits February 15, 2022 17:08
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Copy link
Contributor

@isabela-pf isabela-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! I've been asked to provide some ideas on why having components with accessibility foundations would be beneficial.

I've added a few high-level suggestions, but please let me know if you would like other areas addressed and/or for me to move any of these suggestions elsewhere.

jep/README.md Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
jep/README.md Outdated Show resolved Hide resolved
echarles and others added 5 commits February 24, 2022 10:24
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
@echarles
Copy link
Member

echarles commented Mar 3, 2022

The JEP has been submitted on jupyter/enhancement-proposals#89

Thx all who contributed, I will merge this PR and we can continue the work on the jupyter repo.

@echarles echarles merged commit 2974528 into main Mar 3, 2022
@echarles echarles deleted the jep branch August 18, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants