-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft JEP #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@echarles here are some comments to start the discussion. Overall I confirm we are aligned on the goal for this JEP.
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Thx a lot @fcollonval I have merged you suggestions and replied on 2 comments. I will merge once you undraft. Then we can further discuss and plan the JEP submission. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some minor additional elements and some typos
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Frédéric Collonval <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! I've been asked to provide some ideas on why having components with accessibility foundations would be beneficial.
I've added a few high-level suggestions, but please let me know if you would like other areas addressed and/or for me to move any of these suggestions elsewhere.
Co-authored-by: Frédéric Collonval <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
The JEP has been submitted on jupyter/enhancement-proposals#89 Thx all who contributed, I will merge this PR and we can continue the work on the jupyter repo. |
I opened this PR tot be able to use the comment feature.